fix: prevent unhandled exceptions when processing empty SSE event payloads#214
Merged
Conversation
madhuchavva
reviewed
Jun 25, 2026
madhuchavva
left a comment
madhuchavva
left a comment
Contributor
There was a problem hiding this comment.
Native SSE validation path issue found.
madhuchavva
requested changes
Jun 25, 2026
madhuchavva
left a comment
madhuchavva
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes for the native SSE validation gap noted inline.
madhuchavva
approved these changes
Jun 25, 2026
# Conflicts: # lib/src/main/java/growthbook/sdk/java/repository/GBFeaturesRepository.java # lib/src/main/java/growthbook/sdk/java/repository/NativeJavaGbFeatureRepository.java
vazarkevych
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Empty SSE Event Payload Handling
Overview
This PR prevents unhandled exceptions when SSE events contain an empty or heartbeat payload.
Some SSE servers may send keepalive, heartbeat, ping, or empty
dataevents. Previously, those payloads could still reach feature JSON parsing and fail when the payload was blank or invalid.What Changed
heartbeat,keepalive, andping.